[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] scsi-disk: Add support for port WWN and index d
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH] scsi-disk: Add support for port WWN and index descriptors in VPD page 83h |
Date: |
Thu, 20 Feb 2014 18:54:52 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) |
Paolo Bonzini <address@hidden> writes:
> Il 20/02/2014 17:02, Andreas Färber ha scritto:
>> Not unexpected, it's the older; the - convention was introduced possibly
>> with QOM around start of 2012. Or at least there it's been enforced, and
QMP preferred '-' from the start, but insufficient decoupling from
command line and HMP let in many '_', and the bad examples then got
copied around, as usual.
>> by my understanding of QOM and QMP visibility it then applies to devices
>> as well.
>>
>> Regarding QMP, I consider it smarter to do the _ -> - matching at
>> QemuOpts level than somewhere inside QOM.
>
> That's fine, because device_add uses QemuOpts internally.
>
>> For -cpu we have such compatibility code (although non-QemuOpts) in
>> target-i386/cpu.c, converting all underscores. Unfortunately that won't
>> work as long as there are underscores in old properties. Maybe you have
>> some cool patch idea?
>
> Well, no cool idea except "once conversion is done at the QemuOpts
> level, do a full sweep of s/_/-/".
Required anyway, to get the help texts consistent, and to get rid of the
bad examples.
> This should be done before we'll
> be able to create devices with object-add. I think as long as we have
> a plan, consistency trumps design-by-committee convention.
- [Qemu-devel] [PATCH] scsi-disk: Add support for port WWN and index descriptors in VPD page 83h, Roland Dreier, 2014/02/19
- Re: [Qemu-devel] [PATCH] scsi-disk: Add support for port WWN and index descriptors in VPD page 83h, Paolo Bonzini, 2014/02/19
- Re: [Qemu-devel] [PATCH] scsi-disk: Add support for port WWN and index descriptors in VPD page 83h, Andreas Färber, 2014/02/19
- Re: [Qemu-devel] [PATCH] scsi-disk: Add support for port WWN and index descriptors in VPD page 83h, Roland Dreier, 2014/02/19
- Re: [Qemu-devel] [PATCH] scsi-disk: Add support for port WWN and index descriptors in VPD page 83h, Paolo Bonzini, 2014/02/19
- Re: [Qemu-devel] [PATCH] scsi-disk: Add support for port WWN and index descriptors in VPD page 83h, Paolo Bonzini, 2014/02/20
- Re: [Qemu-devel] [PATCH] scsi-disk: Add support for port WWN and index descriptors in VPD page 83h, Andreas Färber, 2014/02/20
- Re: [Qemu-devel] [PATCH] scsi-disk: Add support for port WWN and index descriptors in VPD page 83h, Paolo Bonzini, 2014/02/20
- Re: [Qemu-devel] [PATCH] scsi-disk: Add support for port WWN and index descriptors in VPD page 83h,
Markus Armbruster <=