[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/8] virtio_get_byteswap: function for endian-am
From: |
Rusty Russell |
Subject: |
Re: [Qemu-devel] [PATCH 1/8] virtio_get_byteswap: function for endian-ambivalent targets using virtio. |
Date: |
Fri, 21 Feb 2014 09:56:46 +1030 |
User-agent: |
Notmuch/0.15.2 (http://notmuchmail.org) Emacs/23.4.1 (x86_64-pc-linux-gnu) |
Alexander Graf <address@hidden> writes:
> On 02/18/2014 05:17 PM, Cornelia Huck wrote:
>> Hm. So whatever_le for 1.0 devices, and virtio_whatever (checking the
>> byteswap value) for legacy devices? The device implementation will be
>> aware of the virtio version anyway.
>
> Yeah, but I would hope we want to share as much code as possible here,
> so that config accessors can be shared between legacy virtio and 1.0
> virtio. And in that case we want to have a generic helper to read/write
> pieces of that config space - which this patch introduces for us :).
>
>> (Btw., can some of those architectures supporting both le/be run with
>> mixed le/be cpus? That would be a mess for legacy devices.)
>
> Yes, they can. No, we don't care :).
There's per-cpu (what endian) and per-device (legacy or no). To do this
Right, we'd need to consult both, but we don't always have that
information. So this the minimal viable solution.
We'll need a per-device legacy flag eventually (there are other changes
than just endian). But getting the wrappers in place is a good first
step.
Cheers,
Rusty.
- Re: [Qemu-devel] [PATCH 1/8] virtio_get_byteswap: function for endian-ambivalent targets using virtio., (continued)
- Re: [Qemu-devel] [PATCH 1/8] virtio_get_byteswap: function for endian-ambivalent targets using virtio., Michael S. Tsirkin, 2014/02/18
- Re: [Qemu-devel] [PATCH 1/8] virtio_get_byteswap: function for endian-ambivalent targets using virtio., Michael S. Tsirkin, 2014/02/18
- Re: [Qemu-devel] [PATCH 1/8] virtio_get_byteswap: function for endian-ambivalent targets using virtio., Alexander Graf, 2014/02/18
- Re: [Qemu-devel] [PATCH 1/8] virtio_get_byteswap: function for endian-ambivalent targets using virtio., Michael S. Tsirkin, 2014/02/18
- Re: [Qemu-devel] [PATCH 1/8] virtio_get_byteswap: function for endian-ambivalent targets using virtio., Alexander Graf, 2014/02/18
- Re: [Qemu-devel] [PATCH 1/8] virtio_get_byteswap: function for endian-ambivalent targets using virtio., Cornelia Huck, 2014/02/18
- Re: [Qemu-devel] [PATCH 1/8] virtio_get_byteswap: function for endian-ambivalent targets using virtio., Cornelia Huck, 2014/02/18
- Re: [Qemu-devel] [PATCH 1/8] virtio_get_byteswap: function for endian-ambivalent targets using virtio., Alexander Graf, 2014/02/18
- Re: [Qemu-devel] [PATCH 1/8] virtio_get_byteswap: function for endian-ambivalent targets using virtio., Cornelia Huck, 2014/02/18
- Re: [Qemu-devel] [PATCH 1/8] virtio_get_byteswap: function for endian-ambivalent targets using virtio., Alexander Graf, 2014/02/18
- Re: [Qemu-devel] [PATCH 1/8] virtio_get_byteswap: function for endian-ambivalent targets using virtio.,
Rusty Russell <=
- Re: [Qemu-devel] [PATCH 1/8] virtio_get_byteswap: function for endian-ambivalent targets using virtio., Andreas Färber, 2014/02/18
- Re: [Qemu-devel] [PATCH 1/8] virtio_get_byteswap: function for endian-ambivalent targets using virtio., Andreas Färber, 2014/02/18
- Re: [Qemu-devel] [PATCH 1/8] virtio_get_byteswap: function for endian-ambivalent targets using virtio., Greg Kurz, 2014/02/19
- Re: [Qemu-devel] [PATCH 1/8] virtio_get_byteswap: function for endian-ambivalent targets using virtio., Rusty Russell, 2014/02/20
- [Qemu-devel] [PATCH 2/8] virtio: allow byte swapping for vring and config access, Greg Kurz, 2014/02/18
- Re: [Qemu-devel] [PATCH 2/8] virtio: allow byte swapping for vring and config access, Cornelia Huck, 2014/02/18
- Re: [Qemu-devel] [PATCH 2/8] virtio: allow byte swapping for vring and config access, Greg Kurz, 2014/02/18
- [Qemu-devel] [PATCH 3/8] hw/net/virtio-net: use virtio wrappers to access headers., Greg Kurz, 2014/02/18
- [Qemu-devel] [PATCH 4/8] hw/net/virtio-balloon: use virtio wrappers to access page frame numbers., Greg Kurz, 2014/02/18
- [Qemu-devel] [PATCH 6/8] hw/scsi/virtio-scsi: use virtio wrappers to access headers., Greg Kurz, 2014/02/18