[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V7 04/11] qapi script: check correctness of disc
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH V7 04/11] qapi script: check correctness of discriminator values in union |
Date: |
Fri, 21 Feb 2014 06:49:18 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
On 02/21/2014 01:21 AM, Markus Armbruster wrote:
>> I'd still rather make it explicit that we KNOW that this branch of the
>> union has no additional options:
>>
>> { 'union': 'FooOptions',
>> 'base': 'CommonFooOptions',
>> 'discriminator': 'type',
>> 'data': { 'plain': {},
>> 'bells': 'BellsOptions',
>> 'whistles': 'WhistlesOptions' } }
>>
>> to show that we explicitly thought about all the cases. We don't
>> currently have any such unions with an empty branch, but it would be
>> worth documenting in the qapi text and explicitly testing that it works
>> if we intend to support this.
>
> Fair point. However, it requires 'plain': {} to work, and it doesn't in
> my testing.
> We should extend the generator to permit {} before we insist on unions
> covering all discriminator values explicitly. Because if we don't,
> people will be compelled to add dummy fields.
So far, we have no one that should be omitting a branch. But yes, I
agree that we should update the generator to allow an empty branch.
In the context of _this_ patch, requiring that all branches are covered
doesn't hurt until a future patch actually has to add a dummy field or
fix the generator. I don't know if it's something Wenchao would like to
add in the next spin, or if we should just live this this patch being a
little over-ambitious on what it enforces in the absence of more generic
support for an explicit empty branch.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
[Qemu-devel] [PATCH V7 10/11] qapi script: do not add "_" for every capitalized char in enum, Wenchao Xia, 2014/02/20
[Qemu-devel] [PATCH V7 08/11] qapi: convert BlockdevOptions to use enum discriminator, Wenchao Xia, 2014/02/20
[Qemu-devel] [PATCH V7 09/11] qapi script: do not allow string discriminator, Wenchao Xia, 2014/02/20
[Qemu-devel] [PATCH V7 11/11] qapi test: add error path test for union, Wenchao Xia, 2014/02/20