[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V19 06/12] quorum: Add quorum mechanism.
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH V19 06/12] quorum: Add quorum mechanism. |
Date: |
Fri, 21 Feb 2014 15:09:42 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
On 02/21/2014 02:21 PM, Benoît Canet wrote:
> From: Benoît Canet <address@hidden>
>
> This patchset enables the core of the quorum mechanism.
> The num_children reads are compared to get the majority version and if this
> version exists more than threshold times the guest won't see the error at all.
> +++ b/docs/qmp/qmp-events.txt
> @@ -500,3 +500,39 @@ Example:
>
> Note: If action is "reset", "shutdown", or "pause" the WATCHDOG event is
> followed respectively by the RESET, SHUTDOWN, or STOP events.
> +
> +QUORUM_FAILURE
> +--------------
This should have been inserted in sorted order to match the rest of the
file, rather than at the end. Can be rearranged in a followup patch,
now that this series is queued.
> +
> +Emitted by the Quorum block driver if it fails to establish a quorum.
> +
> +Data:
> +
> +- "reference": device name if defined else node name.
> +- "sector-num": Number of the first sector of the failed read operation.
I'm assuming sector-num is relative to the guest's view of the data?
> +
> +QUORUM_REPORT_BAD
> +-----------------
> +
> +Emitted to report a corruption of a Quorum file.
> +
> +Data:
> +
> +- "ret": The IO return code.
What values is this likely to contain? Is it a finite set, in which
case it would be nice to have a QAPI enum that describes the set of
return codes, rather than a raw number?
I'd like to make sure we are happy with the wire format of this QMP
event before it gets baked into 2.0.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH V19 12/12] quorum: Add unit test., (continued)
- [Qemu-devel] [PATCH V19 12/12] quorum: Add unit test., Benoît Canet, 2014/02/21
- [Qemu-devel] [PATCH V19 11/12] quorum: Add quorum_open() and quorum_close()., Benoît Canet, 2014/02/21
- [Qemu-devel] [PATCH V19 10/12] quorum: Implement recursive .bdrv_recurse_is_first_non_filter in quorum., Benoît Canet, 2014/02/21
- [Qemu-devel] [PATCH V19 08/12] quorum: Add quorum_invalidate_cache()., Benoît Canet, 2014/02/21
- [Qemu-devel] [PATCH V19 04/12] blkverify: Extract qemu_iovec_clone() and qemu_iovec_compare() from blkverify., Benoît Canet, 2014/02/21
- [Qemu-devel] [PATCH V19 01/12] quorum: Create quorum.c, add QuorumChildRequest and QuorumAIOCB., Benoît Canet, 2014/02/21
- [Qemu-devel] [PATCH V19 03/12] quorum: Add quorum_aio_writev and its dependencies., Benoît Canet, 2014/02/21
- [Qemu-devel] [PATCH V19 07/12] quorum: Add quorum_getlength()., Benoît Canet, 2014/02/21
- [Qemu-devel] [PATCH V19 06/12] quorum: Add quorum mechanism., Benoît Canet, 2014/02/21
- Re: [Qemu-devel] [PATCH V19 06/12] quorum: Add quorum mechanism.,
Eric Blake <=
- Re: [Qemu-devel] [PATCH V19 06/12] quorum: Add quorum mechanism., Benoît Canet, 2014/02/21
- Re: [Qemu-devel] [PATCH V19 06/12] quorum: Add quorum mechanism., Kevin Wolf, 2014/02/21
- Re: [Qemu-devel] [PATCH V19 06/12] quorum: Add quorum mechanism., Eric Blake, 2014/02/21
- Re: [Qemu-devel] [PATCH V19 06/12] quorum: Add quorum mechanism., Benoît Canet, 2014/02/21
- Re: [Qemu-devel] [PATCH V19 06/12] quorum: Add quorum mechanism., Eric Blake, 2014/02/21
- Re: [Qemu-devel] [PATCH V19 06/12] quorum: Add quorum mechanism., Eric Blake, 2014/02/21
[Qemu-devel] [PATCH V19 05/12] quorum: Add quorum_aio_readv., Benoît Canet, 2014/02/21
Re: [Qemu-devel] [PATCH V19 00/12] Quorum block filter, Kevin Wolf, 2014/02/21
Re: [Qemu-devel] [PATCH V19 00/12] Quorum block filter, Eric Blake, 2014/02/21