[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] hw/intc/arm_gic: Fix GIC_SET_LEVEL
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] hw/intc/arm_gic: Fix GIC_SET_LEVEL |
Date: |
Mon, 24 Feb 2014 15:36:48 +0000 |
On 23 February 2014 16:32, Christoffer Dall <address@hidden> wrote:
> On 21 February 2014 17:03, Christoffer Dall <address@hidden> wrote:
>> The GIC_SET_LEVEL macro unfortunately overwrote the entire level
>> bitmask instead of just or'ing on the necessary bits, causing active
>> level PPIs on a core to clear PPIs on other cores.
>>
>> I introduced this bug, sorry about that.
>>
> Actually it turns out this was ancient, I was a little too quick to
> blame myself there.
Yes, it's been present since 2007 or so. Probably not noticed
at that time because all the 11MPcore PPIs are edge rather than
level triggered.
Reviewed-by: Peter Maydell <address@hidden>
I'll remove the line about it being your fault when I apply
this to target-arm.next :-)
thanks
-- PMM