[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] hw/arm/musicpal: Remove nonexistent CDTP2, CDTP
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH] hw/arm/musicpal: Remove nonexistent CDTP2, CDTP3 registers |
Date: |
Mon, 24 Feb 2014 16:55:48 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
Am 24.02.2014 16:45, schrieb Peter Maydell:
> On 21 February 2014 07:15, Jan Kiszka <address@hidden> wrote:
>> On 2014-02-18 16:28, Peter Maydell wrote:
>>> The ethernet device in the musicpal only has two tx queues,
>>> but we modelled it with four CTDP registers, presumably a
>>> cut and paste from the rx queue registers. Since the tx_queue[]
>>> array is only 2 entries long this allowed a guest to overrun
>>> this buffer. Remove the nonexistent registers.
>>>
>>> Signed-off-by: Peter Maydell <address@hidden>
>>
>> Acked-by: Jan Kiszka <address@hidden>
>
> Thanks, applied to target-arm.next (with added cc:stable line).
Jan/Peter, is there any other outstanding work on musicpal that I should
be aware of? If not, I'd like to base the long-planned file splitup on
Peter's next pull. Hopefully we can still get that done for 2.0.
Cheers,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg