Re: [Qemu-devel] [PATCH 26/28] target-ppc: Altivec 2.07: AES Instructions

[Richard Henderson]

On 02/12/2014 01:23 PM, Tom Musta wrote:
> +static uint8_t SBOX[256] = {

I'm not keen on yet another copy of AES data.

Please reuse "qemu/aes.h" as much as possible.  Please see how we use those in
target-i386; from a quick reading, these insns should match up:

  aesenc        vcipher
  aesenclast    vcipherlast
  aesdec        vncipher
  aesdeclast    vncipherlast

It does look like the aes_shifts/aes_ishifts arrays should be moved from i386
specific code.  Which would also be good since ops_sse.h is included multiple
times and thus we have unnecessary multiple copies of this data.

There's more data that should be moved out to common code in
target-arm/crypto_helper.c.  The most pertinent of which is a copy of your SBOX
and InvSBOX arrays, which you'll still need for the vsbox insn.

I'll also note that arm contains a second copy of the aes_{i,}shifts arrays.
So after those are moved to common code, we avoid that duplication too.


r~