[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2 v3] qdev-monitor: set DeviceState opts befor
|
From: |
Andreas Färber |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/2 v3] qdev-monitor: set DeviceState opts before calling realize |
|
Date: |
Tue, 25 Feb 2014 08:39:24 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
Am 25.02.2014 05:34, schrieb Bandan Das:
> Setting opts before the realize property is set allows the
> following patch to make decisions based on whether the user
> specified "rombar". This also avoids having to create a new
> tristate property especially for this purpose
>
> Signed-off-by: Bandan Das <address@hidden>
> ---
> qdev-monitor.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Makes perfect sense,
Reviewed-by: Andreas Färber <address@hidden>
Queuing a copy on qom-next to avoid conflicts with a v2 for Amos' link<>
issue.
Thanks,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg