[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH target-arm v2 6/7] dma/pl330: Fix buffer depth
From: |
Peter Crosthwaite |
Subject: |
[Qemu-devel] [PATCH target-arm v2 6/7] dma/pl330: Fix buffer depth |
Date: |
Tue, 25 Feb 2014 16:00:09 -0800 |
This is the product of the data-width and the depth arguments, I.e the
depth of the FIFO is in terms of data entries and not bytes (which is
what the original implementation was suggesting). Fix.
Signed-off-by: Peter Crosthwaite <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
---
changed since v1:
Remove double space in arith expression (PMM review)
hw/dma/pl330.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/dma/pl330.c b/hw/dma/pl330.c
index 303f8b8..b5d586b 100644
--- a/hw/dma/pl330.c
+++ b/hw/dma/pl330.c
@@ -1606,7 +1606,7 @@ static void pl330_realize(DeviceState *dev, Error **errp)
pl330_queue_init(&s->read_queue, s->rd_q_dep, s);
pl330_queue_init(&s->write_queue, s->wr_q_dep, s);
- pl330_fifo_init(&s->fifo, s->data_buffer_dep);
+ pl330_fifo_init(&s->fifo, s->data_width / 4 * s->data_buffer_dep);
}
static Property pl330_properties[] = {
--
1.9.0.1.g4196000
- [Qemu-devel] [PATCH target-arm v2 0/7] PL330 Changes, Peter Crosthwaite, 2014/02/25
- [Qemu-devel] [PATCH target-arm v2 1/7] dma/pl330: Delete overly verbose debug printf, Peter Crosthwaite, 2014/02/25
- [Qemu-devel] [PATCH target-arm v2 2/7] dma/pl330: Fix misleading type, Peter Crosthwaite, 2014/02/25
- [Qemu-devel] [PATCH target-arm v2 3/7] dma/pl330: printf format type sweep., Peter Crosthwaite, 2014/02/25
- [Qemu-devel] [PATCH target-arm v2 4/7] dma/pl330: Rename parent_obj, Peter Crosthwaite, 2014/02/25
- [Qemu-devel] [PATCH target-arm v2 5/7] dma/pl330: Add event debugging printfs, Peter Crosthwaite, 2014/02/25
- [Qemu-devel] [PATCH target-arm v2 6/7] dma/pl330: Fix buffer depth,
Peter Crosthwaite <=
- [Qemu-devel] [PATCH target-arm v2 7/7] dma/pl330: implement dmaadnh instruction, Peter Crosthwaite, 2014/02/25
- Re: [Qemu-devel] [PATCH target-arm v2 0/7] PL330 Changes, Peter Maydell, 2014/02/26