qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] translate: remove file translate-all.h


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH] translate: remove file translate-all.h
Date: Wed, 26 Feb 2014 11:34:14 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0

Il 26/02/2014 10:55, Peter Maydell ha scritto:
On 26 February 2014 09:25, Xuebing Wang <address@hidden> wrote:
This patch does below:
-   Move the declaration of 2 translate functions from translate-all.h into
    include/exec/exec-all.h
-   remove file translate-all.h

"translate-all.h" => "exec/exec-all.h" can be done by:
git grep -w "translate-all.h" | cut -d: -f1 |
    xargs sed -i 's/\<translate-all.h\>/exec\/exec-all.h/g'

Note:
1)  "exact whole word match" is considered.
2)  We may move translate related from include/exec/exec-all.h into
    include/exec/translate.h later.

Is there any particular benefit to this change? The function
prototypes go from being in a header only included by the file
that uses them to being in a header that's included by a lot
of other code...

Indeed, that's the point of translate-all.h.

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]