[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 0/3] qapi: Allow modularization of QAPI schem
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH v3 0/3] qapi: Allow modularization of QAPI schema files |
|
Date: |
Thu, 27 Feb 2014 14:17:30 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
On 02/27/2014 08:31 AM, Luiz Capitulino wrote:
> On Tue, 11 Feb 2014 14:00:14 +0100
> Lluís Vilanova <address@hidden> wrote:
>
>> Adds the "include(...)" primitive to the syntax of QAPI schema files,
>> allowing
>> these to be modularized into multiple per-topic files in the future.
>
> Markus, Eric, you commented/reviewed v2 of this series. Any comments
> against v3?
A couple nits that still need fixing (see individual messages), but if
you feel comfortable fixing them now instead of waiting for a v4, then
go ahead and add:
Series: Reviewed-by: Eric Blake <address@hidden>
Then again, adding a cycle test for chained inclusion cycles in test 3
may be best with a v4.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature