Re: [Qemu-devel] [PATCH 0/7] timer: move APIs together according to their category

[Alex Bligh]

On 25 Feb 2014, at 13:36, Xuebing Wang wrote:

> There are 6 categories of APIs:
> - QEMUClockType
> - QEMUTimerList
> - QEMUTimerListGroup
> - QEMUTimer
> - General utility functions
> - Low level clock functions
> 
> Problems / solutions with previous API implementations:
> 1) Can not think of cases that we need QEMUTimerList APIs.
>   Reference:  kernel_tree/Documentation/SubmittingPatches
>               -- Section "4) Don't over-design"
>   Purpose:    simplify API
>   Solution:   remove them from APIs
> 2) Implementations of some APIs are interwined
>   Purpose:    put them together according to their categories, thus new
>               engineers are easy to understand them
>   Solution:   put them together
> 3) Unnecessary header files are included
>   Purpose:    simplify the included header files
>   Solution:   only include the minimally required header file
> 
> This patchset includes below changes:
> - put QEMUTimerList related functions together and make them private
> - put QEMUClockType related functions together
> - move QEMUTimerListGroup function to be below QEMUClockType
> - put QEMUTimer related functions together
> - put general utility functions together
> - clean unnecessary #include and use minimal required #include
> 
> Xuebing Wang (7):
>  timer: move QEMUTimerList functions together
>  timer: make QEMUTimerList functions private (remove from APIs)
>  timer: move QEMUClockType related functions together
>  timer: move QEMUTimerListGroup function to be below QEMUClockType
>  timer: move QEMUTimer related functions together
>  timer: move general utility functions together
>  timer: clean unnecessary #include and use minimal required #include
> 
> include/qemu/timer.h |   94 --------
> qemu-timer.c         |  595 +++++++++++++++++++++++++++++---------------------
> 2 files changed, 341 insertions(+), 348 deletions(-)


As far as I can see, this patch set reorders qemu-timer.c in a more
logical way, and removes some functions from timer.h that need not
be exposed.

Therefore, this seems to me a good idea in principle, and:

Reviewed-By: Alex Bligh <address@hidden>

on the lot, subject to the proviso I haven't compile tested them.

-- 
Alex Bligh