[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 13/13] qapi: Add missing null check to opts_start
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH v3 13/13] qapi: Add missing null check to opts_start_struct() |
Date: |
Sat, 1 Mar 2014 08:40:39 +0100 |
Argument is null when visiting an unboxed struct. I can't see such a
visit in the current code. Fix it anyway.
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
---
qapi/opts-visitor.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/qapi/opts-visitor.c b/qapi/opts-visitor.c
index 96ed858..5d830a2 100644
--- a/qapi/opts-visitor.c
+++ b/qapi/opts-visitor.c
@@ -124,7 +124,9 @@ opts_start_struct(Visitor *v, void **obj, const char *kind,
OptsVisitor *ov = DO_UPCAST(OptsVisitor, visitor, v);
const QemuOpt *opt;
- *obj = g_malloc0(size > 0 ? size : 1);
+ if (obj) {
+ *obj = g_malloc0(size > 0 ? size : 1);
+ }
if (ov->depth++ > 0) {
return;
}
--
1.8.1.4
- [Qemu-devel] [PATCH v3 00/13] qapi: Test coverage & clean up generated code, Markus Armbruster, 2014/03/01
- [Qemu-devel] [PATCH v3 04/13] tests/qapi-schema: Cover anonymous union types, Markus Armbruster, 2014/03/01
- [Qemu-devel] [PATCH v3 02/13] tests/qapi-schema: Cover optional command arguments, Markus Armbruster, 2014/03/01
- [Qemu-devel] [PATCH v3 01/13] tests/qapi-schema: Actually check successful QMP command response, Markus Armbruster, 2014/03/01
- [Qemu-devel] [PATCH v3 06/13] tests/qapi-schema: Cover union types with base, Markus Armbruster, 2014/03/01
- [Qemu-devel] [PATCH v3 13/13] qapi: Add missing null check to opts_start_struct(),
Markus Armbruster <=
- [Qemu-devel] [PATCH v3 05/13] tests/qapi-schema: Cover complex types with base, Markus Armbruster, 2014/03/01
- [Qemu-devel] [PATCH v3 11/13] qapi: Clean up null checking in generated visitors, Markus Armbruster, 2014/03/01
- [Qemu-devel] [PATCH v3 09/13] qapi: Drop nonsensical header guard in generated qapi-visit.c, Markus Armbruster, 2014/03/01
- [Qemu-devel] [PATCH v3 08/13] qapi: Fix licensing of scripts, Markus Armbruster, 2014/03/01
- [Qemu-devel] [PATCH v3 12/13] qapi: Clean up superfluous null check in qapi_dealloc_type_str(), Markus Armbruster, 2014/03/01
- [Qemu-devel] [PATCH v3 03/13] tests/qapi-schema: Cover simple argument types, Markus Armbruster, 2014/03/01
- [Qemu-devel] [PATCH v3 10/13] qapi: Drop unused code in qapi-commands.py, Markus Armbruster, 2014/03/01
- [Qemu-devel] [PATCH v3 07/13] tests/qapi-schema: Cover flat union types, Markus Armbruster, 2014/03/01
- Re: [Qemu-devel] [PATCH v3 00/13] qapi: Test coverage & clean up generated code, Luiz Capitulino, 2014/03/03