qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 7/7] allwinner-emac: update irq status after


From: Peter Crosthwaite
Subject: Re: [Qemu-devel] [PATCH v2 7/7] allwinner-emac: update irq status after writes to interrupt registers
Date: Mon, 3 Mar 2014 20:59:40 +1000

On Mon, Mar 3, 2014 at 12:06 AM, Beniamino Galvani <address@hidden> wrote:
> The irq line status must be updated after writes to the INT_CTL and
> INT_STA registers.
>
> Signed-off-by: Beniamino Galvani <address@hidden>

Reviewed-by: Peter Crosthwaite <address@hidden>

> ---
>  hw/net/allwinner_emac.c |    2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/hw/net/allwinner_emac.c b/hw/net/allwinner_emac.c
> index 91931ac..d780ba0 100644
> --- a/hw/net/allwinner_emac.c
> +++ b/hw/net/allwinner_emac.c
> @@ -391,9 +391,11 @@ static void aw_emac_write(void *opaque, hwaddr offset, 
> uint64_t value,
>          break;
>      case EMAC_INT_CTL_REG:
>          s->int_ctl = value;
> +        aw_emac_update_irq(s);
>          break;
>      case EMAC_INT_STA_REG:
>          s->int_sta &= ~value;
> +        aw_emac_update_irq(s);
>          break;
>      case EMAC_MAC_MADR_REG:
>          s->phy_target = value;
> --
> 1.7.10.4
>
>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]