Re: [Qemu-devel] [PATCH 1/3] hw/9pfs/virtio-9p-local.c: move v9fs_string_free() to below "err_out:"

[Aneesh Kumar K.V]

Chen Gang <address@hidden> writes:

> When "goto err_out", 'v9fs_string' already was allocated, so still need
> free 'v9fs_string' before return.
>
> Signed-off-by: Chen Gang <address@hidden>

Reviewed-by: Aneesh Kumar K.V <address@hidden>

> ---
>  hw/9pfs/virtio-9p-local.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/9pfs/virtio-9p-local.c b/hw/9pfs/virtio-9p-local.c
> index fc93e9e..77a04cd 100644
> --- a/hw/9pfs/virtio-9p-local.c
> +++ b/hw/9pfs/virtio-9p-local.c
> @@ -1059,9 +1059,9 @@ static int local_unlinkat(FsContext *ctx, V9fsPath *dir,
>      }
>      /* Remove the name finally */
>      ret = remove(rpath(ctx, fullname.data, buffer));
> -    v9fs_string_free(&fullname);
>
>  err_out:
> +    v9fs_string_free(&fullname);
>      return ret;
>  }
>
> -- 
> 1.7.11.7