[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] qemu-iotests: Test progress output for conv
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 2/2] qemu-iotests: Test progress output for conversion |
Date: |
Mon, 03 Mar 2014 11:20:37 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
On 03/03/2014 06:57 AM, Kevin Wolf wrote:
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> tests/qemu-iotests/086 | 65
> ++++++++++++++++++++++++++++++++++++++++++++++
> tests/qemu-iotests/086.out | 18 +++++++++++++
> tests/qemu-iotests/group | 1 +
> 3 files changed, 84 insertions(+)
> create mode 100755 tests/qemu-iotests/086
> create mode 100644 tests/qemu-iotests/086.out
>
> +
> +$QEMU_IMG convert -p -O $IMGFMT -f $IMGFMT "$TEST_IMG" "$TEST_IMG".base
> 2>&1 |\
> + _filter_testdir | sed -e 's/\r/\n/g'
\r is not portable sed. Alas, coming up with a portable way to
represent carriage return in sed is a bear, so I can live with this
reliance on GNU sed.
> +wrote 1048576/1048576 bytes at offset 33554432
> +1 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
> + (0.00/100%)
> + (25.00/100%)
> + (50.00/100%)
> + (75.00/100%)
> + (100.00/100%)
> + (100.00/100%)
Feels fragile (will it ALWAYS be done in chunks of 25% completion?) but
if it passes reliably, it's always better to have more test coverage.
Can we test the other commands that support -p? And is anyone
interested in adding -p support to more commands (there are several
long-running commands that could use it but don't have it yet).
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature