Re: [Qemu-devel] [Discussion 09/10] exec: remove the unnecessary include of "exec-all.h"

[Paolo Bonzini]

Il 04/03/2014 03:47, Xuebing Wang ha scritto:
> include/exec/exec-all.h should ONLY be included in target-xxx/*
> -   'git grep -nw exec-all.h' confirms this

Ok.

Paolo

> Signed-off-by: Xuebing Wang <address@hidden>
> ---
>  cputlb.c   |    1 -
>  tcg/README |    2 +-
>  tci.c      |    2 +-
>  3 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/cputlb.c b/cputlb.c
> index 724bdda..f1458a6 100644
> --- a/cputlb.c
> +++ b/cputlb.c
> @@ -23,7 +23,6 @@
>  #include "cpu.h" /* target-xxx/cpu.h, required for CPUArchState etc */
>
>  #include "config.h"
> -#include "exec/exec-all.h"
>  #include "exec/memory.h"
>
>  #include "exec/cputlb.h"
> diff --git a/tcg/README b/tcg/README
> index f178212..0788bdc 100644
> --- a/tcg/README
> +++ b/tcg/README
> @@ -530,7 +530,7 @@ register.
>    inline TCG may still be faster for longer sequences.
>
>  - The hard limit on the number of TCG instructions you can generate
> -  per guest instruction is set by MAX_OP_PER_INSTR in exec-all.h --
> +  per guest instruction is set by MAX_OP_PER_INSTR in translate.h --
>    you cannot exceed this without risking a buffer overrun.
>
>  - Use the 'discard' instruction if you know that TCG won't be able to
> diff --git a/tci.c b/tci.c
> index 0202ed9..7b9d0af 100644
> --- a/tci.c
> +++ b/tci.c
> @@ -25,7 +25,7 @@
>  #endif
>
>  #include "qemu-common.h"
> -#include "exec/exec-all.h"           /* MAX_OPC_PARAM_IARGS */
> +#include "exec/translate.h"           /* MAX_OPC_PARAM_IARGS */
>  #include "tcg-op.h"
>
>  /* Marker for missing code. */