[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 05/10] tcg-aarch64: Don't handle mov/movi intcg_
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH 05/10] tcg-aarch64: Don't handle mov/movi intcg_out_opp |
Date: |
Wed, 05 Mar 2014 06:47:48 -0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
On 03/05/2014 04:11 AM, Alex Bennée wrote:
>
> Richard Henderson <address@hidden> writes:
>
>> Signed-off-by: Richard Henderson <address@hidden>
>> ---
>> tcg/aarch64/tcg-target.c | 20 +++++++-------------
>> 1 file changed, 7 insertions(+), 13 deletions(-)
>>
> <snip>
>>
>> + case INDEX_op_mov_i64:
>> + case INDEX_op_mov_i32:
>> + case INDEX_op_movi_i64:
>> + case INDEX_op_movi_i32:
>> + /* Always implemented with tcg_out_mov/i, never with tcg_out_op. */
>> default:
>> - tcg_abort(); /* opcode not implemented */
>> + /* Opcode not implemented. */
>> + tcg_abort();
>> }
>> }
>
> Doesn't this fall through and abort for all mov ops? Have I missed
> somewhere else that ensures the ops don't come via tcg_out_op?
>
Yes, the switch statement in tcg_gen_code_common.
r~
- [Qemu-devel] [PATCH 00/10] tcg/aarch64 cleanups, Richard Henderson, 2014/03/04
- [Qemu-devel] [PATCH 01/10] tcg-aarch64: Enable builtin disassembler, Richard Henderson, 2014/03/04
- [Qemu-devel] [PATCH 03/10] tcg-aarch64: Change all ext variables to TCGType, Richard Henderson, 2014/03/04
- [Qemu-devel] [PATCH 02/10] tcg-aarch64: Remove redundant CPU_TLB_ENTRY_BITS check, Richard Henderson, 2014/03/04
- [Qemu-devel] [PATCH 05/10] tcg-aarch64: Don't handle mov/movi in tcg_out_op, Richard Henderson, 2014/03/04
- [Qemu-devel] [PATCH 07/10] tcg-aarch64: Remove the shift_imm parameter from tcg_out_cmp, Richard Henderson, 2014/03/04
- [Qemu-devel] [PATCH 04/10] tcg-aarch64: Set ext based on TCG_OPF_64BIT, Richard Henderson, 2014/03/04
- [Qemu-devel] [PATCH 06/10] tcg-aarch64: Hoist common argument loads in tcg_out_op, Richard Henderson, 2014/03/04
- [Qemu-devel] [PATCH 09/10] tcg-aarch64: Simplify tcg_out_ldst_9 encoding, Richard Henderson, 2014/03/04
- [Qemu-devel] [PATCH 08/10] tcg-aarch64: Use intptr_t apropriately, Richard Henderson, 2014/03/04