[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/5] block/raw: Strip "file:" prefix from filena
From: |
Benoît Canet |
Subject: |
Re: [Qemu-devel] [PATCH 0/5] block/raw: Strip "file:" prefix from filenames |
Date: |
Thu, 6 Mar 2014 14:07:53 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
The Thursday 06 Mar 2014 à 13:57:55 (+0100), Kevin Wolf wrote :
> Am 05.03.2014 um 22:41 hat Max Reitz geschrieben:
> > The "file" protocol drivers (block/raw-posix and block/raw-win32) may be
> > explicitly selected by prepending a "file:" prefix to a filename (as
> > with all other block protocols). However, currently, they do not strip
> > this prefix as they should.
> >
> > This series fixes this issue.
>
> Thanks, applied to the block branch.
Heh my review was too late :)
>
> This is just for consistency and there is no real use case for this,
> right? If so, it would be even more consistent to do the same for the
> host_* drivers provided by block/raw-{posix,win32}.c
>
> I talked about this multiple times in discussions about handling colons
> in filenames, so that prefixing file: would make it unambigious that the
> colon is part of the file name and not a protocol name, but these days I
> think we already have enough other ways to express this (the easiest
> being ./test:foo, because protocols can't contain slashes)
>
> Kevin
>
- [Qemu-devel] [PATCH 2/5] block/raw-posix: Implement bdrv_parse_filename(), (continued)
- [Qemu-devel] [PATCH 2/5] block/raw-posix: Implement bdrv_parse_filename(), Max Reitz, 2014/03/05
- [Qemu-devel] [PATCH 3/5] block/raw-posix: Strip "file:" prefix on creation, Max Reitz, 2014/03/05
- [Qemu-devel] [PATCH 4/5] block/raw-win32: Implement bdrv_parse_filename(), Max Reitz, 2014/03/05
- [Qemu-devel] [PATCH 5/5] block/raw-win32: Strip "file:" prefix on creation, Max Reitz, 2014/03/05
- Re: [Qemu-devel] [PATCH 0/5] block/raw: Strip "file:" prefix from filenames, Eric Blake, 2014/03/05
- Re: [Qemu-devel] [PATCH 0/5] block/raw: Strip "file:" prefix from filenames, Kevin Wolf, 2014/03/06