qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 3/3] hw/boards: converted current_machine to


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH v3 3/3] hw/boards: converted current_machine to be an instance of MachineCLass
Date: Fri, 07 Mar 2014 17:27:26 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0

Il 07/03/2014 17:22, Marcel Apfelbaum ha scritto:
There is a problem with it: 'make check fails' on test-qdev-global-props.
- 'qdev_get_machine()' is called by 'device_set_realized()' because 
static_prop_type
  has TYPE_DEVICE as parent.
- The machine is added to the QOM tree *only in vl's main* and this test does 
not
  reach it, but assumes that always will be a machine in the QOM tree.
  This is no longer true.

Possible solution would be making existing 'null machine' a subclass of 
MachineClass
and add it manually to QOM on this test(and other places as necessary). The 
risk here is
that there are other places where the machine needs to be added manually to the 
QOM tree.
(I am trying this option, but make check gets stuck !!!, debugging)

This is probably the right thing to do, but I guess it means it's better to leave this series to 2.1.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]