[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5] target-sparc: Add and use CPU_FEATURE_CASA
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH v5] target-sparc: Add and use CPU_FEATURE_CASA |
|
Date: |
Mon, 10 Mar 2014 13:48:19 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
On 03/09/2014 04:02 AM, Sebastian Huber wrote:
> #endif
> +#if !defined(CONFIG_USER_ONLY) || defined(TARGET_SPARC64)
> + case 0x3c: /* V9 or LEON3 casa */
> + CHECK_IU_FEATURE(dc, CASA);
> +#ifndef TARGET_SPARC64
> + if (IS_IMM) {
> + goto illegal_insn;
> + }
> + if (!supervisor(dc)) {
> + goto priv_insn;
> + }
> +#endif
> + rs2 = GET_FIELD(insn, 27, 31);
> + cpu_src2 = gen_load_gpr(dc, rs2);
> + gen_cas_asi(dc, cpu_addr, cpu_src2, insn, rd);
> + break;
> +#endif
Might as well put the feature check inside the ifndef sparc64,
since we know that sparc64 always has the feature.
Otherwise,
Reviewed-by: Richard Henderson <address@hidden>
r~