[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 12/12] hw/pci-host/apb.c: Avoid shifting left in
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH 12/12] hw/pci-host/apb.c: Avoid shifting left into sign bit |
Date: |
Mon, 10 Mar 2014 23:59:10 +0200 |
On Mon, Mar 10, 2014 at 07:10:48PM +0000, Peter Maydell wrote:
> Add U suffix to avoid undefined behaviour.
>
> Signed-off-by: Peter Maydell <address@hidden>
While not required for correctness, it would be cleaner
to change all constants around this line to 1U <<, for consistency.
> ---
> hw/pci-host/apb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/pci-host/apb.c b/hw/pci-host/apb.c
> index 1b399dd..a6869b8 100644
> --- a/hw/pci-host/apb.c
> +++ b/hw/pci-host/apb.c
> @@ -58,7 +58,7 @@ do { printf("APB: " fmt , ## __VA_ARGS__); } while (0)
> #define PBM_PCI_IMR_MASK 0x7fffffff
> #define PBM_PCI_IMR_ENABLED 0x80000000
>
> -#define POR (1 << 31)
> +#define POR (1U << 31)
> #define SOFT_POR (1 << 30)
> #define SOFT_XIR (1 << 29)
> #define BTN_POR (1 << 28)
> --
> 1.9.0
>
- [Qemu-devel] [PATCH 00/12] Avoid shifting left into sign bit, Peter Maydell, 2014/03/10
- [Qemu-devel] [PATCH 03/12] hw/pci/pci_host.c: Avoid shifting left into sign bit, Peter Maydell, 2014/03/10
- [Qemu-devel] [PATCH 06/12] hw/usb/hcd-ohci.c: Avoid shifting left into sign bit, Peter Maydell, 2014/03/10
- [Qemu-devel] [PATCH 12/12] hw/pci-host/apb.c: Avoid shifting left into sign bit, Peter Maydell, 2014/03/10
- Re: [Qemu-devel] [PATCH 12/12] hw/pci-host/apb.c: Avoid shifting left into sign bit,
Michael S. Tsirkin <=
- [Qemu-devel] [PATCH 08/12] hw/ppc: Avoid shifting left into sign bit, Peter Maydell, 2014/03/10
- [Qemu-devel] [PATCH 05/12] target-mips: Avoid shifting left into sign bit, Peter Maydell, 2014/03/10
- [Qemu-devel] [PATCH 04/12] hw/i386/acpi_build.c: Avoid shifting left into sign bit, Peter Maydell, 2014/03/10
- [Qemu-devel] [PATCH 09/12] tests/libqos/pci-pc: Avoid shifting left into sign bit, Peter Maydell, 2014/03/10
- [Qemu-devel] [PATCH 07/12] hw/intc/openpic: Avoid shifting left into sign bit, Peter Maydell, 2014/03/10
- [Qemu-devel] [PATCH 01/12] target-i386: Avoid shifting left into sign bit, Peter Maydell, 2014/03/10
- [Qemu-devel] [PATCH 10/12] hw/intc/slavio_intctl: Avoid shifting left into sign bit, Peter Maydell, 2014/03/10