[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V2 2/2] tests: Tweak the Makefile to produce per
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH V2 2/2] tests: Tweak the Makefile to produce per-test output. |
Date: |
Tue, 11 Mar 2014 06:07:29 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
On 03/11/2014 04:09 AM, Marcel Apfelbaum wrote:
> From: Stefan Hajnoczi <address@hidden>
>
> The effect is that the output will grow, but we will know
> which qtest failed. This helps when an asert is made on
s/asert/assert/
> other code and not in the test itself.
>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> Signed-off-by: Marcel Apfelbaum <address@hidden>
> ---
> tests/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/Makefile b/tests/Makefile
> index b17d41e..a8405c8 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -273,7 +273,7 @@ check-help:
> @echo "changed with variable GTESTER_OPTIONS."
>
> SPEED = quick
> -GTESTER_OPTIONS = -k $(if $(V),--verbose,-q)
> +GTESTER_OPTIONS = -k #$(if $(V),--verbose,-q)
Isn't this effectively commenting out the rest of the line? If so, why
not delete everything after the #?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
[Qemu-devel] [PATCH V2 2/2] tests: Tweak the Makefile to produce per-test output., Marcel Apfelbaum, 2014/03/11