[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 09/10] migration: expose the bitmap_sync_cnt to
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 09/10] migration: expose the bitmap_sync_cnt to the end user |
Date: |
Tue, 11 Mar 2014 07:22:21 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
On 03/11/2014 06:53 AM, address@hidden wrote:
> From: ChenLiang <address@hidden>
>
> expose the counter that log the times of updating the dirty bitmap to
> end user.
>
> Signed-off-by: ChenLiang <address@hidden>
> Signed-off-by: Gonglei <address@hidden>
> ---
> +++ b/qapi-schema.json
> @@ -651,13 +651,15 @@
> #
> # @mbps: throughput in megabits/sec. (since 1.6)
> #
> +# @dirty-sync-cnt: the times of ram dirty sync (since 1.7)
The earliest this will make it in is 2.0 - and that's if it is treated
as a bug fix. Otherwise, this needs to be '(since 2.1)'.
'cnt' is an abbreviation; it doesn't hurt to spell things out to say
'dirty-sync-count'.
> @@ -2966,6 +2967,7 @@ Examples:
> "duplicate":123,
> "normal":123,
> "normal-bytes":123456
> + "dirty-sync-cnt":15
Invalid JSON. If dirty-sync-cnt is present, "normal-bytes":123456 must
have a comma separating the two elements.
> }
> }
> }
> @@ -2991,6 +2993,7 @@ Examples:
> "duplicate":123,
> "normal":123,
> "normal-bytes":123456
> + "dirty-sync-cnt":15
And again. All of your insertions to this example need correction.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 06/10] migraion: optimiztion xbzrle by reducing data copy, (continued)
- [Qemu-devel] [PATCH 05/10] migration: Fix the migrate auto converge process, arei.gonglei, 2014/03/11
- [Qemu-devel] [PATCH 03/10] XBZRLE: optimize XBZRLE to decrease the cache missing, arei.gonglei, 2014/03/11
- [Qemu-devel] [PATCH 09/10] migration: expose the bitmap_sync_cnt to the end user, arei.gonglei, 2014/03/11
- [Qemu-devel] [PATCH 07/10] migraion: clear the death code, arei.gonglei, 2014/03/11
- [Qemu-devel] [PATCH 08/10] migration: s/uint64_t/int64_t the definitions of it_age, arei.gonglei, 2014/03/11
- [Qemu-devel] [PATCH 10/10] XBZRLE: update the doc of XBZRLE, arei.gonglei, 2014/03/11
- [Qemu-devel] [PATCH 02/10] migration: Add counters of updating the dirty bitmap, arei.gonglei, 2014/03/11