Re: [Qemu-devel] [PATCH] blockdev: Refuse to open encrypted image unless paused

[Paolo Bonzini]

Il 13/03/2014 14:27, Eric Blake ha scritto:
> > > >> +    } else if (!runstate_check(RUN_STATE_PRELAUNCH)
> > > >> +            && !runstate_check(RUN_STATE_PAUSED)) { /* HACK */
> > >
> > > Why not "if (runstate_is_running())"?
> Because that lacks PRELAUNCH, but PRELAUNCH also needs the protection.

Nope, PRELAUNCH does *not* need the protection.

if (!runstate_check(PRELAUNCH) && !runstate_check(PAUSED)) error

        gives an error if runstate == anything *but*
        PRELAUNCH and PAUSED

It's at least DEBUG, SAVE_VM and RESTORE_VM that do need it but are not 
included in runstate_is_running.

Paolo