|
From: | Paolo Bonzini |
Subject: | Re: [Qemu-devel] [PATCH] blockdev: Refuse to open encrypted image unless paused |
Date: | Thu, 13 Mar 2014 15:19:02 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 |
Il 13/03/2014 14:27, Eric Blake ha scritto:
>> + } else if (!runstate_check(RUN_STATE_PRELAUNCH) >> + && !runstate_check(RUN_STATE_PAUSED)) { /* HACK */> > Why not "if (runstate_is_running())"?Because that lacks PRELAUNCH, but PRELAUNCH also needs the protection.
Nope, PRELAUNCH does *not* need the protection. if (!runstate_check(PRELAUNCH) && !runstate_check(PAUSED)) error gives an error if runstate == anything *but* PRELAUNCH and PAUSEDIt's at least DEBUG, SAVE_VM and RESTORE_VM that do need it but are not included in runstate_is_running.
Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |