Re: [Qemu-devel] [PATCH v2 5/9] hbitmap: Add hbitmap_copy

[Paolo Bonzini]

Il 13/03/2014 14:45, Benoît Canet ha scritto:
> This feel wrong:
>
> struct HBitmap {
>     /* Number of total bits in the bottom level.  */
>     uint64_t size;
>
> The comment about size imply that size apply only to the bottom level.
>
> Moreover the bitmaps are progressivelly less coarse so I think the size you use
> should goes down as you go up to the top.

Correct.  You can reuse the computation in hbitmap_alloc instead.

Paolo