qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] update names in option tables to match with


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH v2] update names in option tables to match with actual command-line spelling
Date: Mon, 17 Mar 2014 11:50:39 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0

Il 17/03/2014 09:23, Markus Armbruster ha scritto:
> This patch makes all names in option table to match with actual
> command-line spelling, it will be helpful when we search in option
> tables.

As discussed in [*], the QemuOptsList member name values are ABI:
changing them can break existing -readconfig configuration files.  If we
decide breaking ABI is okay here (big if!), we need to document it
prominently in the commit message.

I think in some (rare) cases breaking the rule is okay. For example, the pending conversion of "-m" to QemuOpts uses "memory".

However, I don't think adding "-opts" is a good thing to do. Which one is most readable?

   [m]
      size = 128M
      max = 512M

   [memory]
      size = 128M
      max = 512M

   [memory-opts]
      size = 128M
      max = 512M

I'm for including this patch in 2.0.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]