Re: [Qemu-devel] [PATCH v2] convert fprintf() calls to error_setg() in block/qed.c:bdrv_qed_create()

[Stefan Hajnoczi]

On Sat, Mar 15, 2014 at 03:05:23PM +0530, Aakriti Gupta wrote:
> This patch converts fprintf() calls to error_setg() in 
> block/qed.c:bdrv_qed_create()
> (error_setg() is part of error reporting API in include/qapi/error.h)
> 
> Signed-off-by: Aakriti Gupta <address@hidden>
> ---
>  block/qed.c |    8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Acked-by: Stefan Hajnoczi <address@hidden>

>      if (!qed_is_cluster_size_valid(cluster_size)) {
> -        fprintf(stderr, "QED cluster size must be within range [%u, %u] and 
> power of 2\n",
> +        error_setg(errp, "QED cluster size must be within range [%u, %u] and 
> power of 2",
>                  QED_MIN_CLUSTER_SIZE, QED_MAX_CLUSTER_SIZE);

Kevin: Do you want to fix up the indentation of the next line when
merging?