[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 8/8] dataplane: fix implicit IOThread refcount
From: |
Kevin Wolf |
Subject: |
[Qemu-devel] [PULL 8/8] dataplane: fix implicit IOThread refcount |
Date: |
Wed, 19 Mar 2014 14:12:07 +0100 |
From: Stefan Hajnoczi <address@hidden>
When creating an IOThread implicitly (the user did not specify
x-iothread=<id>) remember that iothread_find() does not return the
object with an incremented refcount.
Signed-off-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Fam Zheng <address@hidden>
Signed-off-by: Kevin Wolf <address@hidden>
---
hw/block/dataplane/virtio-blk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-blk.c
index a5afc21..f558b45 100644
--- a/hw/block/dataplane/virtio-blk.c
+++ b/hw/block/dataplane/virtio-blk.c
@@ -393,7 +393,6 @@ void virtio_blk_data_plane_create(VirtIODevice *vdev,
VirtIOBlkConf *blk,
if (blk->iothread) {
s->internal_iothread = false;
s->iothread = blk->iothread;
- object_ref(OBJECT(s->iothread));
} else {
/* Create per-device IOThread if none specified */
Error *local_err = NULL;
@@ -408,6 +407,7 @@ void virtio_blk_data_plane_create(VirtIODevice *vdev,
VirtIOBlkConf *blk,
s->iothread = iothread_find(vdev->name);
assert(s->iothread);
}
+ object_ref(OBJECT(s->iothread));
s->ctx = iothread_get_aio_context(s->iothread);
/* Prevent block operations that conflict with data plane thread */
--
1.8.3.1
- [Qemu-devel] [PULL 0/8] Block patches for 2.0.0-rc1, Kevin Wolf, 2014/03/19
- [Qemu-devel] [PULL 1/8] block: Add error handling to bdrv_invalidate_cache(), Kevin Wolf, 2014/03/19
- [Qemu-devel] [PULL 2/8] qemu-io-cmds: Fixed typo in example for writev., Kevin Wolf, 2014/03/19
- [Qemu-devel] [PULL 3/8] qemu-io: Extended "--cmd" description in usage text, Kevin Wolf, 2014/03/19
- [Qemu-devel] [PULL 4/8] qcow2: Correct comment for realloc_refcount_block(), Kevin Wolf, 2014/03/19
- [Qemu-devel] [PULL 6/8] block/nfs: bump libnfs requirement to 1.9.3, Kevin Wolf, 2014/03/19
- [Qemu-devel] [PULL 5/8] qcow2: Fix fail path in realloc_refcount_block(), Kevin Wolf, 2014/03/19
- [Qemu-devel] [PULL 7/8] block/nfs: report errors from libnfs, Kevin Wolf, 2014/03/19
- [Qemu-devel] [PULL 8/8] dataplane: fix implicit IOThread refcount,
Kevin Wolf <=
- Re: [Qemu-devel] [PULL 0/8] Block patches for 2.0.0-rc1, Peter Maydell, 2014/03/19