[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] virtio-net: Do not filter VLANs without F_CTRL_
From: |
Stefan Fritsch |
Subject: |
Re: [Qemu-devel] [PATCH] virtio-net: Do not filter VLANs without F_CTRL_VLAN |
Date: |
Wed, 19 Mar 2014 23:38:57 +0100 |
User-agent: |
KMail/4.11.5 (Linux/3.13-1-amd64; KDE/4.11.5; x86_64; ; ) |
Hi,
Am Dienstag, 25. Februar 2014, 11:06:33 schrieb Amos Kong:
> > > On Wed, Feb 12, 2014 at 10:46:28PM +0100, Stefan Fritsch wrote:
> > > > If VIRTIO_NET_F_CTRL_VLAN is not negotiated, do not filter out
> > > > all
> > > > VLAN-tagged packets but send them to the guest.
AFAICS, no fix has been committed, yet. Is there anything I need to do
to get this fixed?
> > > Can we just update receive_filter() to filter out VLAN-tagged
> > > packets only when VIRTIO_NET_F_CTRL_VLAN is negotiated?
>
> If we change receive_filter(), we also need a flag to indicate
> management this feature isn't negotiated, management will do some
> additional operation to host device to get same effect.
>
>
> > We could. But this adds a (very small) per-packet overhead while
> > my patch only adds overhead during reset. Therefore I didn't
> > take that approach. But if changing receive_filter() makes
> > management much easier, that could be acceptable.
>
> Actually your solution is better, QEMU will return a long list
> [0,1,2,...4095] to management, host device will filter all the vlan
> packets and send to QEMU.
>
> So the problem raised by mst doesn't exist.
Cheers,
Stefan
- Re: [Qemu-devel] [PATCH] virtio-net: Do not filter VLANs without F_CTRL_VLAN,
Stefan Fritsch <=