[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL for 2.0 5/5] w32: Replace Windows specific data t
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PULL for 2.0 5/5] w32: Replace Windows specific data types in common header files |
Date: |
Thu, 20 Mar 2014 15:00:03 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
Am 20.03.2014 07:25, schrieb Stefan Weil:
> These header files are used by most QEMU source files. If they
> depend on windows.h, all those source files do so, too.
>
> All Windows specific data types which are replaced use identical
> definitions for the 32 and 64 bit Windows APIs. HANDLE, LONG
> and CRITICAL_SECTION are replaced by the compatible types
> WinHandle, WinLong and WinCriticalSection.
>
> Add an explicit dependency on qemu/winapi.h for some files which need it.
> These sources use the Windows API (see comment after include statement)
> and no longer get windows.h indirectly from other header files.
>
> A workaround which was added in the previous patch is no longer needed.
>
> Now 175 *.o files remain which still depend on windows.h.
>
> Cc: Anthony Liguori <address@hidden>
> Cc: Stefan Hajnoczi <address@hidden>
> Cc: Andreas Färber <address@hidden>
> Signed-off-by: Stefan Weil <address@hidden>
> Reviewed-by: Stefan Hajnoczi <address@hidden>
For the record, I'm okay with WinHandle. I thought someone had
objections against some struct, but seems I missed either a discussion
or a respin.
Regards,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- [Qemu-devel] [PULL for 2.0 0/5] MinGW related patches, Stefan Weil, 2014/03/20
- [Qemu-devel] [PULL for 2.0 4/5] w32: Reduce dependencies in sysemu/os-win32.h, Stefan Weil, 2014/03/20
- [Qemu-devel] [PULL for 2.0 3/5] w32: Move inline function from header file to C source, Stefan Weil, 2014/03/20
- [Qemu-devel] [PULL for 2.0 2/5] w32: Add and use intermediate include file for windows.h, Stefan Weil, 2014/03/20
- [Qemu-devel] [PULL for 2.0 5/5] w32: Replace Windows specific data types in common header files, Stefan Weil, 2014/03/20
- Re: [Qemu-devel] [PULL for 2.0 5/5] w32: Replace Windows specific data types in common header files,
Andreas Färber <=
- [Qemu-devel] [PULL for 2.0 1/5] gtk: Support GTK without VTE, Stefan Weil, 2014/03/20
- Re: [Qemu-devel] [PULL for 2.0 0/5] MinGW related patches, Stefan Weil, 2014/03/20