[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 03/10] migration: expose the bitmap_sync_coun
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v3 03/10] migration: expose the bitmap_sync_counter to the end user |
Date: |
Thu, 20 Mar 2014 13:28:44 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
On 03/18/2014 06:24 AM, address@hidden wrote:
> From: ChenLiang <address@hidden>
>
> expose the counter that log the times of updating the dirty bitmap to
s/log/logs/
> end user.
>
> Signed-off-by: ChenLiang <address@hidden>
> Signed-off-by: Gonglei <address@hidden>
> ---
> arch_init.c | 1 +
> hmp.c | 2 ++
> include/migration/migration.h | 1 +
> migration.c | 2 ++
> qapi-schema.json | 4 +++-
> qmp-commands.hx | 13 +++++++++----
> 6 files changed, 18 insertions(+), 5 deletions(-)
>
> +++ b/qapi-schema.json
> @@ -651,13 +651,15 @@
> #
> # @mbps: throughput in megabits/sec. (since 1.6)
> #
> +# @dirty-sync-counter: the times of ram dirty sync (since 2.1)
The name could possibly be shortened. Also, this sentence reads
awkwardly. Maybe:
@dirty-sync-count: number of times that dirty ram was synchronized
(since 2.1)
> +++ b/qmp-commands.hx
> @@ -2928,6 +2928,7 @@ The main json-object contains the following:
> pages. This is just normal pages times size of one page,
> but this way upper levels don't need to care about page
> size (json-int)
> + - "dirty-sync-counter": the times of ram dirty sync (json-int)
and if you do change the wording above (or even shorten the variable
name), make it match here
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v3 04/10] migration: expose xbzrle cache miss rate, (continued)
- [Qemu-devel] [PATCH v3 02/10] migration: Add counters of updating the dirty bitmap, arei.gonglei, 2014/03/18
- [Qemu-devel] [PATCH v3 08/10] migration: optimize xbzrle by reducing data copy, arei.gonglei, 2014/03/18
- [Qemu-devel] [PATCH v3 07/10] migration: Fix the migrate auto converge process, arei.gonglei, 2014/03/18
- [Qemu-devel] [PATCH v3 05/10] XBZRLE: optimize XBZRLE to decrease the cache missing, arei.gonglei, 2014/03/18
- [Qemu-devel] [PATCH v3 10/10] XBZRLE: update the doc of XBZRLE, arei.gonglei, 2014/03/18
- [Qemu-devel] [PATCH v3 03/10] migration: expose the bitmap_sync_counter to the end user, arei.gonglei, 2014/03/18
- Re: [Qemu-devel] [PATCH v3 03/10] migration: expose the bitmap_sync_counter to the end user,
Eric Blake <=
- [Qemu-devel] [PATCH v3 06/10] XBZRLE: rebuild the cache_is_cached function, arei.gonglei, 2014/03/18
- [Qemu-devel] [PATCH v3 09/10] migration: clear the dead code, arei.gonglei, 2014/03/18
- Re: [Qemu-devel] [PATCH v3 00/10] migration: Optimizate the xbzrle and fix two corruption issues, Eric Blake, 2014/03/20