qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH for-2.0 2/2] dataplane: replace iothread object_


From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [PATCH for-2.0 2/2] dataplane: replace iothread object_add() with embedded instance
Date: Fri, 21 Mar 2014 09:43:08 +0100
User-agent: Mutt/1.5.21 (2010-09-15)

On Thu, Mar 20, 2014 at 03:37:54PM +0100, Paolo Bonzini wrote:
> Il 20/03/2014 15:06, Stefan Hajnoczi ha scritto:
> >+        object_initialize(&s->internal_iothread_obj,
> >+                          sizeof(s->internal_iothread_obj),
> >+                          TYPE_IOTHREAD);
> >+        user_creatable_complete(OBJECT(&s->internal_iothread_obj), 
> >&error_abort);
> 
> Perhaps you need an object_property_add_child here?  Otherwise the
> link points to an object without a canonical path.  Can do it as a
> follow-up though.

The link doesn't exist yet since we're still using a qdev property.

I will add the child property when we switch to a link in QEMU 2.1.  In
order to do that, I posted an RFC series that shows how I propose to
clean up the virtio transport/device split which is currently broken.

Stefan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]