[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 5/9] error: Print error_report() to stderr if usi
From: |
Cole Robinson |
Subject: |
[Qemu-devel] [PATCH v2 5/9] error: Print error_report() to stderr if using qmp |
Date: |
Fri, 21 Mar 2014 19:42:24 -0400 |
monitor_printf will drop the requested output if cur_mon is qmp (for
good reason). However these messages are often helpful for debugging
issues with via libvirt.
If we know the message won't hit the monitor, send it to stderr.
Cc: Luiz Capitulino <address@hidden>
Cc: Markus Armbruster <address@hidden>
Signed-off-by: Cole Robinson <address@hidden>
---
util/qemu-error.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/util/qemu-error.c b/util/qemu-error.c
index 80df49a..7b167fd 100644
--- a/util/qemu-error.c
+++ b/util/qemu-error.c
@@ -20,7 +20,7 @@
*/
void error_vprintf(const char *fmt, va_list ap)
{
- if (cur_mon) {
+ if (cur_mon && !monitor_cur_is_qmp()) {
monitor_vprintf(cur_mon, fmt, ap);
} else {
vfprintf(stderr, fmt, ap);
--
1.8.5.3
- [Qemu-devel] [PATCH v2 0/9] error: Misc cleanups and improvements, Cole Robinson, 2014/03/21
- [Qemu-devel] [PATCH v2 1/9] slirp: Remove default_mon usage, Cole Robinson, 2014/03/21
- [Qemu-devel] [PATCH v2 3/9] error: Privatize error_print_loc, Cole Robinson, 2014/03/21
- [Qemu-devel] [PATCH v2 4/9] monitor: Remove unused monitor_print_filename, Cole Robinson, 2014/03/21
- [Qemu-devel] [PATCH v2 6/9] qerror.h: Remove unused error classes, Cole Robinson, 2014/03/21
- [Qemu-devel] [PATCH v2 5/9] error: Print error_report() to stderr if using qmp,
Cole Robinson <=
- [Qemu-devel] [PATCH v2 7/9] qerror.h: Remove QERR defines that are only used once, Cole Robinson, 2014/03/21
- [Qemu-devel] [PATCH v2 8/9] qerror.h: Replace QERR_NOT_SUPPORTED with QERR_UNSUPPORTED, Cole Robinson, 2014/03/21
- [Qemu-devel] [PATCH v2 9/9] error: Remove some unused headers, Cole Robinson, 2014/03/21
- [Qemu-devel] [PATCH v2 2/9] vnc: Remove default_mon usage, Cole Robinson, 2014/03/21
- Re: [Qemu-devel] [PATCH v2 0/9] error: Misc cleanups and improvements, Paolo Bonzini, 2014/03/22
- Re: [Qemu-devel] [PATCH v2 0/9] error: Misc cleanups and improvements, Luiz Capitulino, 2014/03/27