Re: [Qemu-devel] [RFC PATCH 03/12] migration: make qemu_savevm_state public.

[Frederic Konrad]

On 21/03/2014 20:54, Dr. David Alan Gilbert wrote:
> * address@hidden (address@hidden) wrote:
> > From: KONRAD Frederic <address@hidden>
> >
> > This makes qemu_savevm_state public for reverse-execution.
> It's interesting that you're doing this repetitive snapshot;
> in some ways it's similar to Michael Hines's code for
> Fault tolerance ( 
> http://lists.gnu.org/archive/html/qemu-devel/2014-02/msg03042.html )
>
> Dave

Hi,

Thanks for the link I missed this.

Seems mc is using live migration and we just checkpoint the whole machine.

That might be a good improvment.

Fred

> > Signed-off-by: KONRAD Frederic <address@hidden>
> > ---
> >   include/sysemu/sysemu.h | 1 +
> >   savevm.c                | 2 +-
> >   2 files changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h
> > index 3915ce3..fe86615 100644
> > --- a/include/sysemu/sysemu.h
> > +++ b/include/sysemu/sysemu.h
> > @@ -78,6 +78,7 @@ void do_info_snapshots(Monitor *mon, const QDict *qdict);
> >   
> >   void qemu_announce_self(void);
> >   
> > +int qemu_savevm_state(QEMUFile *f);
> >   bool qemu_savevm_state_blocked(Error **errp);
> >   void qemu_savevm_state_begin(QEMUFile *f,
> >                                const MigrationParams *params);
> > diff --git a/savevm.c b/savevm.c
> > index d094fbb..e50b716 100644
> > --- a/savevm.c
> > +++ b/savevm.c
> > @@ -635,7 +635,7 @@ void qemu_savevm_state_cancel(void)
> >       }
> >   }
> >   
> > -static int qemu_savevm_state(QEMUFile *f)
> > +int qemu_savevm_state(QEMUFile *f)
> >   {
> >       int ret;
> >       MigrationParams params = {
> > --
> > 1.8.1.4
> --
> Dr. David Alan Gilbert / address@hidden / Manchester, UK