[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCHv2] block: optimize zero writes with bdrv_write_z
From: |
Peter Lieven |
Subject: |
Re: [Qemu-devel] [PATCHv2] block: optimize zero writes with bdrv_write_zeroes |
Date: |
Tue, 01 Apr 2014 22:38:09 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 |
Am 28.03.2014 16:53, schrieb Eric Blake:
> On 03/28/2014 08:46 AM, Peter Lieven wrote:
>> this patch tries to optimize zero write requests
>> by automatically using bdrv_write_zeroes if it is
>> supported by the format.
>>
>> This significantly speeds up file system initialization and
>> should speed zero write test used to test backend storage
>> performance.
>>
>> block.c | 39 ++++++++++++++++++++++++++++++++++++++-
>> include/block/block_int.h | 12 ++++++++++++
>> include/qemu-common.h | 1 +
>> qemu-options.hx | 6 ++++++
>> util/iov.c | 21 +++++++++++++++++++++
>> 5 files changed, 78 insertions(+), 1 deletion(-)
>>
> Is there any QMP query- command that can expose the current setting of
> this value? Is this something worth making changeable during runtime?
> Is it something that can be requested per-disk at hotplug time?
currently there is no qmp query command I would add it to "query-block" if
noone has objections.
I don't think that its needed to change this at runtime.
Setting it at hotplug time is, of course, reasonable.
I will look at this and send a respin.
Thanks for the suggestions,
Peter