Re: [Qemu-devel] [PATCH for-2.0 0/7] SMBus and tmp105 fixes

[Michael S. Tsirkin]

On Mon, Mar 31, 2014 at 11:58:57PM +0200, Andreas Färber wrote:
> Hi,
> 
> Am 31.03.2014 18:26, schrieb Paolo Bonzini:
> > This is a resend of the I2C patches I posted a while ago.
> > Patches 1-3 are just a rebase.
> > 
> > Patch 4 is the same as before, patches 5-7 make the tmp105
> > testcase more complete in order to test that change.
> > 
> > Paolo Bonzini (7):
> >   smbus: allow returning an error from reads
> >   smbus: return -1 if nothing found at the given address
> >   pm_smbus: correctly report unclaimed cycles
> 
> I've reviewed these and they look sane and safe for 2.0.
> mst, could you have a second look as PC maintainer and take them?

I'd rather delay to 2.1.
It's not a regression is it?

> >   tmp105: read temperature in milli-celsius
> >   tmp105-test: wrap simple building blocks for testing
> >   tmp105-test: add a second sensor and test that one
> >   tmp105-test: test QOM property and precision
> 
> Thanks, this is more than I would've done myself or asked for. I've
> re-broken the text paragraphs of 4/7 to fit into 76 chars and filled in
> the commit info in 7/7:
> https://github.com/afaerber/qemu-cpu/commits/qom-next
> 
> And for the record, this demonstrates how pretty much any I2C device
> (such as ds1338) can be tested for lack of other libqos drivers: Add it
> via -device to n800 or n810 machine using a free address (such as 0x49
> here) and give the device an ID for accessing it via
> /machine/peripheral/<id> (just shorthand <id> here, I let that slip
> through).
> 
> >  hw/i2c/pm_smbus.c      |  63 +++++++++++++++--------
> >  hw/i2c/smbus.c         |  68 +++++++++++++++++--------
> >  hw/misc/tmp105.c       |   8 +--
> >  include/hw/i2c/smbus.h |  18 +++----
> >  roms/SLOF              |   2 +-
> >  roms/openbios          |   2 +-
> >  roms/qemu-palcode      |   2 +-
> >  roms/seabios           |   2 +-
> >  tests/tmp105-test.c    | 136 
> > +++++++++++++++++++++++++++++++++++++++++--------
> >  9 files changed, 220 insertions(+), 81 deletions(-)
> 
> This diffstat luckily differs from the patches. Please double-check your
> setup. :)
> 
> Regards,
> Andreas
> 
> -- 
> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg