Re: [Qemu-devel] [PATCH v17 12/14] block: Add blockdev-backup to transaction

[Fam Zheng]

On Mon, 04/07 15:11, Eric Blake wrote:
> On 03/10/2014 01:26 AM, Fam Zheng wrote:
> > Signed-off-by: Fam Zheng <address@hidden>
> > ---
> >  blockdev.c       | 48 ++++++++++++++++++++++++++++++++++++++++++++++++
> >  qapi-schema.json |  1 +
> >  2 files changed, 49 insertions(+)
> > 
> 
> > +++ b/qapi-schema.json
> > @@ -1972,6 +1972,7 @@
> >    'data': {
> >         'blockdev-snapshot-sync': 'BlockdevSnapshot',
> >         'drive-backup': 'DriveBackup',
> > +       'blockdev-backup': 'BlockdevBackup',
> >         'abort': 'Abort',
> >         'blockdev-snapshot-internal-sync': 'BlockdevSnapshotInternal'
> >     } }
> 
> It might be nice to mention that the union was expanded in 2.1;
> something like:
> 
> # A discriminated record of operations that can be performed with
> # @transaction.
> #
> # Since 1.1, blockdev-backup since 2.1
> ##
> { 'union': 'TransactionAction',
> 
> Of course, this is a pre-existing problem, as we've added other actions
> since 1.1 (blockdev-snapshot-internal-sync in 1.7, for example), so it
> could be justified as a separate patch.  But it can't hurt to start
> being more thorough in our docs.
> 

OK, I'll add this to comment.

Thanks,
Fam