Re: [Qemu-devel] [SeaBIOS] [SeaBIOS v3 PATCH] SMBIOS: Check for full tables & entry point in fw_cfg

[Gerd Hoffmann]

On Mo, 2014-04-14 at 15:30 -0400, Gabriel L. Somlo wrote:
> If QEMU adds its (still optional) type 0 structure, SeaBIOS just uses
> everything as-is. If no type 0 structure is found, we generate and
> prepend our own, and update the entry point fields accordingly.
> 
> I expect the latter to be the common case (having QEMU add its own
> type 0 sub-table is rare, and discouraged in practice, according to
> the QEMU guys).

[ it's probably a good idea to update the qemu docs explicitly say so ]

> Finally, it feels like BIOS_NAME and BIOS_DATE should maybe come from
> some other, more central place in the SeaBIOS tree, but didn't find
> anything applicable...

Looks good to me too.  The remaining issues which are to be sorted are
on the qemu side only.

cheers,
  Gerd