[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 2/4] util/fifo: Generalise for common integer
From: |
Beniamino Galvani |
Subject: |
Re: [Qemu-devel] [PATCH v4 2/4] util/fifo: Generalise for common integer widths |
Date: |
Tue, 15 Apr 2014 19:26:35 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Mon, Apr 14, 2014 at 08:18:56PM -0700, Peter Crosthwaite wrote:
> Add support for 16, 32 and 64 bit width FIFOs. The push and pop
> functions are replicated to accept all four different integer types.
> The element width of the FIFO is set at creation time.
>
> The backing storage for all element types is still uint8_t regardless of
> element width so some save-load logic is needed to handle endianness
> issue WRT VMSD.
>
> Signed-off-by: Peter Crosthwaite <address@hidden>
> ---
> changed since v3:
> Initialised buffer_size properly (Beniamino review)
> changed since v2:
> replicated (and glueified) the push/pop functions (Don Slutz review).
> Fix "each each" typo (Beniamino review).
> Done use "Case(n):" (Beniamino review).
>
> hw/char/serial.c | 4 +-
> hw/net/allwinner_emac.c | 6 +--
> hw/ssi/xilinx_spi.c | 4 +-
> hw/ssi/xilinx_spips.c | 4 +-
> include/qemu/fifo.h | 33 ++++++++++---
> util/fifo.c | 121
> +++++++++++++++++++++++++++++++++++++-----------
> 6 files changed, 128 insertions(+), 44 deletions(-)
Looks good to me,
Reviewed-by: Beniamino Galvani <address@hidden>
- [Qemu-devel] [PATCH v4 0/4] Generalise FIFO to more integer types, Peter Crosthwaite, 2014/04/14
- [Qemu-devel] [PATCH v4 1/4] util/fifo: Generalise naming scheme, Peter Crosthwaite, 2014/04/14
- [Qemu-devel] [PATCH v4 2/4] util/fifo: Generalise for common integer widths, Peter Crosthwaite, 2014/04/14
- [Qemu-devel] [PATCH v4 3/4] ssi: pl022: Send debug info to stderr, Peter Crosthwaite, 2014/04/14
- [Qemu-devel] [PATCH v4 4/4] ssi: pl022: Convert to use FIFO, Peter Crosthwaite, 2014/04/14
- Re: [Qemu-devel] [PATCH v4 0/4] Generalise FIFO to more integer types, Peter Crosthwaite, 2014/04/16