Re: [Qemu-devel] [PATCH 4/5] blockdev: Clean up fragile use of error_is_set()

[Kevin Wolf]

Am 24.04.2014 um 11:15 hat Markus Armbruster geschrieben:
> Using error_is_set(ERRP) to find out whether a function failed is
> either wrong, fragile, or unnecessarily opaque.  It's wrong when ERRP
> may be null, because errors go undetected when it is.  It's fragile
> when proving ERRP non-null involves a non-local argument.  Else, it's
> unnecessarily opaque (see commit 84d18f0).
> 
> The error_is_set(errp) in internal_snapshot_prepare() is merely
> fragile, because the caller never passes a null errp argument.
> 
> Make the code more robust and more obviously correct: receive the
> error in a local variable, then propagate it through the parameter.
> 
> Signed-off-by: Markus Armbruster <address@hidden>

Reviewed-by: Kevin Wolf <address@hidden>