[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/2] qapi: add a special string in c_type()'s
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 2/2] qapi: add a special string in c_type()'s result to each redundant space |
|
Date: |
Fri, 25 Apr 2014 06:42:30 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 |
On 04/25/2014 01:56 AM, Amos Kong wrote:
> Currently we always add a space after c_type in mcgen(), there is
> some redundant space in generated code. The space isn't needed for
> points by the coding style.
s/points/pointers/
>
> char * value;
> ^
> qapi_free_NameInfo(NameInfo * obj)
> ^
>
> This patch added a special string 'EATSPACE' in the end of c_type()'s
Present tense for what a patch does: s/added/adds/
> result only for point type. The string and the following space will be
s/point type/pointer types/
> striped in mcgen().
s/striped/stripped/
>
> Signed-off-by: Amos Kong <address@hidden>
> ---
> scripts/qapi-commands.py | 2 +-
> scripts/qapi.py | 11 ++++++-----
> 2 files changed, 7 insertions(+), 6 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature