[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v25 31/31] QemuOpts: cleanup tmp 'allocated' mem
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v25 31/31] QemuOpts: cleanup tmp 'allocated' member from QemuOptsList |
Date: |
Fri, 25 Apr 2014 15:43:27 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, Apr 11, 2014 at 01:54:27AM +0800, Chunyan Liu wrote:
> /* Realloc dst option list and append options from an option list (list)
> * to it. dst could be NULL or a malloced list.
> + * Result dst has shorter lifetime then input list.
s/then/than/
But I think it's helpful to be more explicit:
The lifetime of dst must be shorter than the input list because the
QemuOptDesc->name, ->help, and ->def_value_str strings are shared.
- [Qemu-devel] [PATCH v25 21/31] raw-win32.c: replace QEMUOptionParameter with QemuOpts, (continued)
- [Qemu-devel] [PATCH v25 21/31] raw-win32.c: replace QEMUOptionParameter with QemuOpts, Chunyan Liu, 2014/04/11
- [Qemu-devel] [PATCH v25 22/31] raw_bsd.c: replace QEMUOptionParameter with QemuOpts, Chunyan Liu, 2014/04/11
- [Qemu-devel] [PATCH v25 27/31] vhdx.c: replace QEMUOptionParameter with QemuOpts, Chunyan Liu, 2014/04/11
- [Qemu-devel] [PATCH v25 25/31] ssh.c: replace QEMUOptionParameter with QemuOpts, Chunyan Liu, 2014/04/11
- [Qemu-devel] [PATCH v25 24/31] sheepdog.c: replace QEMUOptionParameter with QemuOpts, Chunyan Liu, 2014/04/11
- [Qemu-devel] [PATCH v25 23/31] rbd.c: replace QEMUOptionParameter with QemuOpts, Chunyan Liu, 2014/04/11
- [Qemu-devel] [PATCH v25 26/31] vdi.c: replace QEMUOptionParameter with QemuOpts, Chunyan Liu, 2014/04/11
- [Qemu-devel] [PATCH v25 28/31] vmdk.c: replace QEMUOptionParameter with QemuOpts, Chunyan Liu, 2014/04/11
- [Qemu-devel] [PATCH v25 29/31] vpc.c: replace QEMUOptionParameter with QemuOpts, Chunyan Liu, 2014/04/11
- [Qemu-devel] [PATCH v25 31/31] QemuOpts: cleanup tmp 'allocated' member from QemuOptsList, Chunyan Liu, 2014/04/11
- Re: [Qemu-devel] [PATCH v25 31/31] QemuOpts: cleanup tmp 'allocated' member from QemuOptsList,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH v25 30/31] cleanup QEMUOptionParameter, Chunyan Liu, 2014/04/11
- Re: [Qemu-devel] [PATCH v25 00/31] replace QEMUOptionParameter with QemuOpts, Stefan Hajnoczi, 2014/04/25
- Re: [Qemu-devel] [PATCH v25 00/31] replace QEMUOptionParameter with QemuOpts, Chunyan Liu, 2014/04/21