[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] configure: make source tree build more robus
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v2] configure: make source tree build more robust |
Date: |
Mon, 28 Apr 2014 16:40:33 +0100 |
On 28 April 2014 15:23, Michael S. Tsirkin <address@hidden> wrote:
> @@ -5179,7 +5187,7 @@ do
> done
> mkdir -p $DIRS
> for f in $FILES ; do
> - if [ -e "$source_path/$f" ] && [ "$source_path" != `pwd` ]; then
> + if [ -e "$source_path/$f" ] && [ "$pwd_is_source_path" != "y" ]; then
> symlink "$source_path/$f" "$f"
> fi
> done
It seems a bit silly to do the "are we in the source
directory?" check for every file rather than just once
outside the loop, but that's a separate bug so we should
address it in a separate patch (or ignore it ;-))
thanks
-- PMM