qemu-devel
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 23/35] acpi:piix4: make plug/unlug callbacks gen

From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 23/35] acpi:piix4: make plug/unlug callbacks generic
Date: Tue, 29 Apr 2014 13:55:42 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 
Il 29/04/2014 11:44, Michael S. Tsirkin ha scritto:

> I disagree.  In fact, I think the opposite is true: the three
> functions you mention should take a PCIDevice*, and when this is
> done acpi_memory_plug_cb should be changed to take a DIMMDevice*
> too.

Well this just means we'll need another chipset-independent wrapper
to detect the correct hotplug type?
Yes, we could do that. Calling the wrapper is equivalent to the "broadcast" concept you mentioned, though of course the implementations differ. 

Paolo
reply via email to
[Prev in Thread] Current Thread [Next in Thread]