Re: [Qemu-devel] [PATCH 1/3] kvm: add kvm_enable_cap_{vm,vcpu}

[Alexander Graf]

On 29.04.14 15:52, Cornelia Huck wrote:
> Provide helper functions for enabling capabilities (on a vcpu and on a vm).
>
> Reviewed-by: Thomas Huth <address@hidden>
> Signed-off-by: Cornelia Huck <address@hidden>
> ---
>   include/sysemu/kvm.h |   28 ++++++++++++++++++++++++++++
>   1 file changed, 28 insertions(+)
>
> diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h
> index 0bee1e8..02a9f7a 100644
> --- a/include/sysemu/kvm.h
> +++ b/include/sysemu/kvm.h
> @@ -294,6 +294,34 @@ bool kvm_arch_stop_on_emulation_error(CPUState *cpu);
>   
>   int kvm_check_extension(KVMState *s, unsigned int extension);
>   
> +#define kvm_enable_cap_vm(s, capability, ...)                        \

Please use the existing word ordering - kvm_vm_enable_cap(). And I think 
it makes sense to pass through "flags" as well.

Otherwise I like the patch set :).


Alex