Re: [Qemu-devel] [PATCH] Nowadays alsa and pulseaudio are most often the default soundsystem. When the headerfiles are found, enable the build of the alsa and pulseaudio audio driver for the default targetos.

[Peter Maydell]

On 1 May 2014 11:56, Sander Eikelenboom <address@hidden> wrote:
> Signed-off-by: Sander Eikelenboom <address@hidden>
> ---
>  configure |    6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/configure b/configure
> index 2fbec59..de87d38 100755
> --- a/configure
> +++ b/configure
> @@ -637,6 +637,12 @@ Haiku)
>  ;;
>  *)
>    audio_drv_list="oss"
> +  if test -f /usr/include/sys/asoundlib.h ; then
> +    audio_drv_list="$audio_drv_list alsa"
> +  fi
> +  if test -f /usr/include/pulse/pulseaudio.h ; then
> +    audio_drv_list="$audio_drv_list pa"
> +  fi
>    audio_possible_drivers="oss alsa sdl esd pa"
>    linux="yes"
>    linux_user="yes"

This is a lower-quality duplicate of the code we already
have in configure for probing whether an audio backend
is present (for instance it doesn't allow for the possibility
that the headers have been installed elsewhere). It would
be better to update the existing probe code to distinguish
between "must be present", "don't use" and "use if present"
for each audio driver, in the same way we do for other
features. Then we could just set the default list here
to "maybe-pa maybe-alsa oss" (syntax off the top of my
head, feel free to have a better idea).

thanks
-- PMM