Re: [Qemu-devel] [PATCH V5 07/28] qapi event: convert SHUTDOWN

[Eric Blake]

On 04/30/2014 10:26 PM, Wenchao Xia wrote:
> Signed-off-by: Wenchao Xia <address@hidden>
> ---
>  vl.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)

This, and many of the subsequent patches in the series, are a bit
misleading; I have to go back to 5/28 to make sure that both pieces of
the conversion are in sync.  Is there a technical reason why you can't
provide both the qapi definition and the conversion to the new
qapi_event_send_FOO function in the same patch, one patch per FOO,
rather than your current split?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature