[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 00/26] Merge ppc32/ppc64 tcg backends
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH 00/26] Merge ppc32/ppc64 tcg backends |
Date: |
Fri, 02 May 2014 09:43:09 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 |
On 05/02/2014 09:30 AM, Ulrich Weigand wrote:
> Richard Henderson <address@hidden> wrote on 01.05.2014 17:44:21:
>
>> Please review, and if you've got an ELFv2 system (nudge nudge), please
>> give it a try and make sure it works.
>
> I ran into illegal instructions due to this patch:
>
>> tcg-ppc64: Support mulsh_i32
> [snip]
>> case INDEX_op_muluh_i32:
>> tcg_out32(s, MULHWU | TAB(args[0], args[1], args[2]));
>> break;
>> + case INDEX_op_mulsh_i32:
>> + tcg_out32(s, MULHW | TAB(args[1], args[2], args[3]));
>> + break;
>
> I guess that needs to be args[0], args[1], args[2] as well.
>
> With that change, I was able to start both qemu-system-x86_64 and
> qemu-system-ppc64 and have them run through the respective BIOS/
> SLOF bootup sequence.
Whoops. That what I get for rearranging the patches at the last minute.
r~
- [Qemu-devel] [PATCH 19/26] tcg-ppc64: Support mulsh_i32, (continued)
- [Qemu-devel] [PATCH 19/26] tcg-ppc64: Support mulsh_i32, Richard Henderson, 2014/05/01
- [Qemu-devel] [PATCH 21/26] tcg-ppc: Remove the backend, Richard Henderson, 2014/05/01
- [Qemu-devel] [PATCH 20/26] tcg-ppc64: Merge ppc32 shifts, Richard Henderson, 2014/05/01
- [Qemu-devel] [PATCH 22/26] tcg-ppc: Rename the tcg/ppc64 backend, Richard Henderson, 2014/05/01
- [Qemu-devel] [PATCH 24/26] tcg-ppc: Merge cache-utils into the backend, Richard Henderson, 2014/05/01
- [Qemu-devel] [PATCH 25/26] tcg-ppc64: Use the return address as a base pointer, Richard Henderson, 2014/05/01
- [Qemu-devel] [PATCH 23/26] qemu/osdep: Remove the need for qemu_init_auxval, Richard Henderson, 2014/05/01
- [Qemu-devel] [PATCH 26/26] tcg-ppc: Streamline USE_DIRECT_JUMP, Richard Henderson, 2014/05/01
- Re: [Qemu-devel] [PATCH 00/26] Merge ppc32/ppc64 tcg backends, Tom Musta, 2014/05/02
- Re: [Qemu-devel] [PATCH 00/26] Merge ppc32/ppc64 tcg backends, Ulrich Weigand, 2014/05/02
- Re: [Qemu-devel] [PATCH 00/26] Merge ppc32/ppc64 tcg backends,
Richard Henderson <=