[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v12 4/4] qapi: Add a primitive to include other
From: |
Luiz Capitulino |
Subject: |
Re: [Qemu-devel] [PATCH v12 4/4] qapi: Add a primitive to include other files from a QAPI schema file |
Date: |
Mon, 5 May 2014 16:31:01 -0400 |
On Fri, 2 May 2014 15:52:41 +0200
Lluís Vilanova <address@hidden> wrote:
> --- a/scripts/qapi.py
> +++ b/scripts/qapi.py
> @@ -11,6 +11,8 @@
> # This work is licensed under the terms of the GNU GPL, version 2.
> # See the COPYING file in the top-level directory.
>
> +import os
> +import re
> from ordereddict import OrderedDict
> import os
> import sys
> @@ -36,9 +38,17 @@ builtin_type_qtypes = {
> 'uint64': 'QTYPE_QINT',
> }
You're importing os twice in this series. I saw this while applying an
unrelated patch on top. I'll drop the import added by this patch, please
reply ACKing or NACKing.
- [Qemu-devel] [PATCH v12 0/4] qapi: Allow modularization of QAPI schema files, Lluís Vilanova, 2014/05/02
- [Qemu-devel] [PATCH v12 1/4] qapi: [trivial] Break long command lines, Lluís Vilanova, 2014/05/02
- [Qemu-devel] [PATCH v12 2/4] qapi: [trivial] Do not catch unknown exceptions in "test-qapi.py", Lluís Vilanova, 2014/05/02
- [Qemu-devel] [PATCH v12 3/4] qapi: Use an explicit input file, Lluís Vilanova, 2014/05/02
- [Qemu-devel] [PATCH v12 4/4] qapi: Add a primitive to include other files from a QAPI schema file, Lluís Vilanova, 2014/05/02
- Re: [Qemu-devel] [PATCH v12 0/4] qapi: Allow modularization of QAPI schema files, Luiz Capitulino, 2014/05/05